Fix dataCategoryName: close parenthesized data category list with RPAREN - #142
Open
rickroesler wants to merge 1 commit into
Open
Fix dataCategoryName: close parenthesized data category list with RPAREN#142rickroesler wants to merge 1 commit into
rickroesler wants to merge 1 commit into
Conversation
The second alternative of the dataCategoryName rule ended with LPAREN instead of RPAREN, so valid multi-category filters such as WITH DATA CATEGORY Geography__c ABOVE_OR_BELOW (usa__c, uk__c) failed to parse. Adds regression tests to both npm and jvm targets and a changelog entry. Implemented by codex (gpt-5.6-sol); committed by orchestrator on its behalf. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #141
Change
One token in
antlr/BaseApexParser.g4: the second alternative ofdataCategoryNameclosed the parenthesized list withLPARENinstead ofRPAREN, so valid multi-categoryWITH DATA CATEGORYfilters failed to parse.dataCategoryName : soqlId - | LPAREN soqlId (COMMA soqlId)* LPAREN; + | LPAREN soqlId (COMMA soqlId)* RPAREN;Tests
Added three regression tests to
SOQLParserTestin both the npm and jvm targets, using the example queries verbatim from the Salesforce WITH DATA CATEGORY documentation: single category (ABOVE usa__c), parenthesized list (AT (usa__c, uk__c)), and AND-joined selections.Verified fail-first: with the unmodified grammar, the parenthesized-list test fails with exactly one syntax error at the closing
); the other tests pass. With the fix: npm suite 96/96 (8 suites), jvm 94/94 viamvn package(SOQLParserTest 23/23).Also added a
## UnreleasedCHANGELOG entry following the convention from #125.🤖 Generated with Claude Code